[
https://issues.apache.org/jira/browse/ARTEMIS-4007?focusedWorklogId=810829&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-810829
]
ASF GitHub Bot logged work on ARTEMIS-4007:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/22 15:11
Start Date: 21/Sep/22 15:11
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4228:
URL: https://github.com/apache/activemq-artemis/pull/4228#discussion_r976638456
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/config/impl/ConfigurationImpl.java:
##########
@@ -2848,6 +2849,19 @@ public Configuration
setSuppressSessionNotifications(boolean suppressSessionNoti
return this;
}
+ @Override
+ public String getStatus() {
+ return status;
+ }
+
+ // This value can reflect a desired state (revision) of config. Useful when
configurationFileRefreshPeriod > 0
Review Comment:
/** */
Issue Time Tracking
-------------------
Worklog Id: (was: 810829)
Time Spent: 2h (was: 1h 50m)
> properties config - complete feedback loop with server status attribute
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-4007
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4007
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.25.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Following on from ARTEMIS-4001 - in kubernetties - where properties can be
> mounted as projections of config maps, there can be a large delay between
> update and the refresh being visible to the broker.
> Adding a status attribute to the server control that is driven by
> configuration, will allow properties files to embed version or status
> information and see those reflected via admin or jolokia queries.
> This then provides a nice feedback loop. I am calling it status like MetaData
> [status|https://kubernetes.io/docs/concepts/overview/working-with-objects/kubernetes-objects/#:~:text=The%20status%20describes%20the%20current,the%20desired%20state%20you%20supplied],
> but also leaving it free form such that any sensible json can be embedded
> once there is coordination.
> Initially the value will just be set like any property.
> Eventually it could provide an entry point for the parser to inform of
> property key=value mismatch or errors on update in some "error" section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
