[
https://issues.apache.org/jira/browse/AMQ-9217?focusedWorklogId=844094&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844094
]
ASF GitHub Bot logged work on AMQ-9217:
---------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/23 11:39
Start Date: 07/Feb/23 11:39
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #965:
URL: https://github.com/apache/activemq/pull/965#issuecomment-1420634443
Also, I am wondering if this change should actually have a flag at
all..seems like it's just a bug and should be fixed for
IndividualDeadLetterStrategy. I think the only thing that really makes sense is
to have an audit per DLQ destination.
If a user has enabled a DLQ per destination and are using something like
Virtual Topics it is pretty weird to only DLQ one of the messages to one of the
destinations if there are several consumer queues and more than one consumer
caused the message to go to the DLQ. I guess someone reading the DLQ could be
using a wildcard consumer so they would end up with duplicates which is a
behavior change but if doing that then it would make more sense to use the
shared strategy.
Maybe for a future release (like 5.18.0 or 5.19.0) for 5.18.0 we change the
default behavior so that the individual strategy defaults to using an audit per
destination as that seems like the more "correct" thing to do while keeping a
flag to disable it i guess.
Issue Time Tracking
-------------------
Worklog Id: (was: 844094)
Remaining Estimate: 0h
Time Spent: 10m
> Add config flag to support per-destination audit in AbstractDeadLetterStrategy
> ------------------------------------------------------------------------------
>
> Key: AMQ-9217
> URL: https://issues.apache.org/jira/browse/AMQ-9217
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Fix For: 5.18.0, 5.17.4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> By default, dead letter strategies are shared per destination policy. This
> breaks for IndividualDeadLetterStrategy destination policies, where if the
> same message is DLQ'd from two queues (ie. Virtual Destination forwarding),
> only one message will be permitted to DLQ.
> A flag to enable a fix for this in 5.17.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
