[
https://issues.apache.org/jira/browse/AMQ-9217?focusedWorklogId=844327&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844327
]
ASF GitHub Bot logged work on AMQ-9217:
---------------------------------------
Author: ASF GitHub Bot
Created on: 08/Feb/23 12:11
Start Date: 08/Feb/23 12:11
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #965:
URL: https://github.com/apache/activemq/pull/965#issuecomment-1422497968
@mattrpav - I reworked this a bit and have a commit here as a follow on to
yours that I think makes a bit more sense:
https://github.com/cshannon/activemq/commit/bf30a92809d49c7857843af7fdcbc95a114640cd
It simplifies things and drops the flag as I think it's just a bug that
should be fixed. The more I think about it the more it just seems completely
wrong to not have an audit per DLQ destination. I didn't do much with the tests
so that would need to be looked at. I also wonder if 10k is too high and maybe
we should lower the default because of memory usage.
The last thing is I don't really like the LRU cache we have, it's super
outdated. It would be much better to use something like Caffeine where we don't
need to synchronize. That being said, that's probably a bigger task as we'd
need to pull in that dependency and I would think we'd just want to replace it
everywhere, not just here. Also, (in theory) the DLQ stuff shouldn't be hit all
the time so hopefully performance wouldn't be a big deal as I wouldn't normally
expect a ton of attempts to acquire the lock at the same time but I guess it's
possible if things are going really bad.
Issue Time Tracking
-------------------
Worklog Id: (was: 844327)
Time Spent: 1h 40m (was: 1.5h)
> Add config flag to support per-destination audit in AbstractDeadLetterStrategy
> ------------------------------------------------------------------------------
>
> Key: AMQ-9217
> URL: https://issues.apache.org/jira/browse/AMQ-9217
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Fix For: 5.18.0, 5.17.4
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> By default, dead letter strategies are shared per destination policy. This
> breaks for IndividualDeadLetterStrategy destination policies, where if the
> same message is DLQ'd from two queues (ie. Virtual Destination forwarding),
> only one message will be permitted to DLQ.
> A flag to enable a fix for this in 5.17.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
