[
https://issues.apache.org/jira/browse/AMQ-9217?focusedWorklogId=844181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844181
]
ASF GitHub Bot logged work on AMQ-9217:
---------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/23 21:02
Start Date: 07/Feb/23 21:02
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #965:
URL: https://github.com/apache/activemq/pull/965#discussion_r1099235884
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/AbstractDeadLetterStrategy.java:
##########
@@ -31,13 +31,15 @@ public abstract class AbstractDeadLetterStrategy implements
DeadLetterStrategy {
private boolean processNonPersistent = false;
private boolean processExpired = true;
private boolean enableAudit = true;
- private final ActiveMQMessageAudit messageAudit = new
ActiveMQMessageAudit();
Review Comment:
Also if we decide to not have a flag for Individual and only use a message
audit per destination (which I think makes more sense) then we can actually
just move this message audit variable down into the Shared strategy. The
abstract wouldn't need to have anything defined except the abstract method for
looking up the message audit as leaving this here wouldn't make sense if it
won't be used by Individual.
Issue Time Tracking
-------------------
Worklog Id: (was: 844181)
Time Spent: 1.5h (was: 1h 20m)
> Add config flag to support per-destination audit in AbstractDeadLetterStrategy
> ------------------------------------------------------------------------------
>
> Key: AMQ-9217
> URL: https://issues.apache.org/jira/browse/AMQ-9217
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Fix For: 5.18.0, 5.17.4
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> By default, dead letter strategies are shared per destination policy. This
> breaks for IndividualDeadLetterStrategy destination policies, where if the
> same message is DLQ'd from two queues (ie. Virtual Destination forwarding),
> only one message will be permitted to DLQ.
> A flag to enable a fix for this in 5.17.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
