[
https://issues.apache.org/jira/browse/AMQ-9217?focusedWorklogId=844178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-844178
]
ASF GitHub Bot logged work on AMQ-9217:
---------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/23 20:56
Start Date: 07/Feb/23 20:56
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #965:
URL: https://github.com/apache/activemq/pull/965#discussion_r1099228408
##########
activemq-broker/src/main/java/org/apache/activemq/broker/region/policy/AbstractDeadLetterStrategy.java:
##########
@@ -108,20 +111,25 @@ public void setExpiration(long expiration) {
this.expiration = expiration;
}
+
+
public int getMaxProducersToAudit() {
- return messageAudit.getMaximumNumberOfProducersToTrack();
+ return this.maxProducersToAudit;
}
public void setMaxProducersToAudit(int maxProducersToAudit) {
- messageAudit.setMaximumNumberOfProducersToTrack(maxProducersToAudit);
+ this.maxProducersToAudit = maxProducersToAudit;
}
public void setMaxAuditDepth(int maxAuditDepth) {
- messageAudit.setAuditDepth(maxAuditDepth);
+ this.maxAuditDepth = maxAuditDepth;
Review Comment:
This sets the variable but no longer sets the shared audit so that will
break things.
Issue Time Tracking
-------------------
Worklog Id: (was: 844178)
Time Spent: 1h (was: 50m)
> Add config flag to support per-destination audit in AbstractDeadLetterStrategy
> ------------------------------------------------------------------------------
>
> Key: AMQ-9217
> URL: https://issues.apache.org/jira/browse/AMQ-9217
> Project: ActiveMQ
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Fix For: 5.18.0, 5.17.4
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> By default, dead letter strategies are shared per destination policy. This
> breaks for IndividualDeadLetterStrategy destination policies, where if the
> same message is DLQ'd from two queues (ie. Virtual Destination forwarding),
> only one message will be permitted to DLQ.
> A flag to enable a fix for this in 5.17.x
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
