[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862281
]
ASF GitHub Bot logged work on ARTEMIS-4291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/23 16:35
Start Date: 25/May/23 16:35
Worklog Time Spent: 10m
Work Description: naude-r commented on code in PR #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487#discussion_r1205770107
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/ActiveMQMetricsPlugin.java:
##########
@@ -26,4 +26,10 @@ public interface ActiveMQMetricsPlugin extends Serializable {
ActiveMQMetricsPlugin init(Map<String, String> options);
MeterRegistry getRegistry();
+
+ /**
+ * Allow additional binders to be bound at the right time
+ */
+ default void bind() {
Review Comment:
yes,
we do:
```
new ProcessorMetrics().bindTo(meterRegistry);
new UptimeMetrics().bindTo(meterRegistry);
```
Issue Time Tracking
-------------------
Worklog Id: (was: 862281)
Time Spent: 40m (was: 0.5h)
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
