[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862351
]
ASF GitHub Bot logged work on ARTEMIS-4291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/May/23 19:53
Start Date: 25/May/23 19:53
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1563429260
I'm concerned this may break existing users since the name of the JVM and
Netty metrics are doing to change now. Can you speak to this?
Issue Time Tracking
-------------------
Worklog Id: (was: 862351)
Time Spent: 1.5h (was: 1h 20m)
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
