[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862403&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862403
]
ASF GitHub Bot logged work on ARTEMIS-4291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/May/23 06:10
Start Date: 26/May/23 06:10
Worklog Time Spent: 10m
Work Description: naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1563857150
consider the following two metrics as scraped by prometheus:
```
artemis_address_size{address="ExpiryQueue",broker="$FQDN",endpoint="metrics-port",instance="$IP:8161",job="artemis",namespace="infra",service="artemis-exporters"}
jvm_info{endpoint="metrics-port",instance="$IP:8161",job="artemis",namespace="infra",runtime="OpenJDK
Runtime Environment",service="artemis-exporters",vendor="Red Hat,
Inc.",version="17.0.5+8-LTS"}
```
the only way to link the two metrics are the "instance" tag, which in our
case is a raw ip (broker running external to k8s and k8s endpoints only
supports ip addresses). the "broker" contains a user friendly name which make
the dashboard easier to use.
in my opinion there is no way that adding a "broker" tag can break any
existing dashboards and/or expectation. the cardinality will also not increase
since the same broker tag/value pair is already available from the address
metrics.
hope that make sense?
Issue Time Tracking
-------------------
Worklog Id: (was: 862403)
Time Spent: 1h 40m (was: 1.5h)
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
