[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862918
]
ASF GitHub Bot logged work on ARTEMIS-4291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/23 06:04
Start Date: 31/May/23 06:04
Worklog Time Spent: 10m
Work Description: naude-r commented on PR #4487:
URL:
https://github.com/apache/activemq-artemis/pull/4487#issuecomment-1569549272
> Yes, that makes sense. Before I merge it can you add a test to ensure that
the {{broker}} tag is set on the JVM & Netty metrics as expected? You could
modify {{org.apache.activemq.artemis.tests.integration.plugin.JvmMetricsTest}}
for the JVM metrics. However, we don't have an existing test for the Netty
metrics so you could copy the aforementioned {{JvmMetricsTest}} and modify it
for the Netty use-case.
>
> To be clear, just about every commit needs a test to validate the change
is working as expected and to mitigate against future regressions.
certainly. will get to it either today or tomorrow.
Issue Time Tracking
-------------------
Worklog Id: (was: 862918)
Time Spent: 2h (was: 1h 50m)
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
