[
https://issues.apache.org/jira/browse/ARTEMIS-4291?focusedWorklogId=862981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-862981
]
ASF GitHub Bot logged work on ARTEMIS-4291:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/23 10:14
Start Date: 31/May/23 10:14
Worklog Time Spent: 10m
Work Description: naude-r opened a new pull request, #4487:
URL: https://github.com/apache/activemq-artemis/pull/4487
ARTEMIS-4291 Add the "broker" tag in a consistent manner to all exported
metrics.
Some scrapers, e.g. prometheus, add an "instance" tag. This value may not be
the same as
the broker name, which results in these metrics becoming more difficult to
match up with
the corresponding broker.
Issue Time Tracking
-------------------
Worklog Id: (was: 862981)
Time Spent: 2.5h (was: 2h 20m)
> Some metrics do not have the "broker" tag
> -----------------------------------------
>
> Key: ARTEMIS-4291
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4291
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.28.0
> Reporter: Roelof Naude
> Priority: Minor
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Some metrics do not have the "broker" tag. The "broker" may not match the
> "instance" added by e.g. prometheus, leading to a mismatch.
> [MetricsManager|https://github.com/apache/activemq-artemis/blob/2.28.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/metrics/MetricsManager.java]
> should ideally add "broker" to the common tags, e.g:
> {code:java}
> meterRegistry.config().commonTags("broker", brokerName);{code}
>
> [PR 4487|https://github.com/apache/activemq-artemis/pull/4487] was submitted
> to resolve this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
