[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870613
]
ASF GitHub Bot logged work on ARTEMIS-4360:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:16
Start Date: 12/Jul/23 14:16
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261249473
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##########
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
Ok. Then I'll actually ask. I was confused why you changed the existing
assertion check to an Assume, which will skip rather than fail the test?
Originally it used an assertTrue that would fail if tripped, and then you had
tried to add an explicit fail here at first, but then switched it to the
[semi-duplicated] assumeTrue instead.
Issue Time Tracking
-------------------
Worklog Id: (was: 870613)
Time Spent: 1.5h (was: 1h 20m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> ----------------------------------------------------------
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
