[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870765
]
ASF GitHub Bot logged work on ARTEMIS-4360:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jul/23 10:27
Start Date: 13/Jul/23 10:27
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1262358988
##########
pom.xml:
##########
@@ -1287,6 +1286,12 @@
<skipLeakTests>false</skipLeakTests>
</properties>
</profile>
+ <profile>
+ <id>compatibility-tests</id>
Review Comment:
Those ones at least have the case of applying to lots of modules, and
setting the prop is often the only effect of the profile.
This one is entirely specific to compatibility-tests, which already has the
profile itself, which does more than just setting the prop, so it would seem
nicer if it was all together in the module. (You also just had to make 2 fixup
commits that were basically the result of splitting such prop updates).
Issue Time Tracking
-------------------
Worklog Id: (was: 870765)
Time Spent: 3h 10m (was: 3h)
> Make compatibility-tests opt in with -Pcompatibility-tests
> ----------------------------------------------------------
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
