[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870650&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870650
]
ASF GitHub Bot logged work on ARTEMIS-4360:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 17:17
Start Date: 12/Jul/23 17:17
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261482609
##########
pom.xml:
##########
@@ -1276,7 +1276,6 @@
<skipJoramTests>false</skipJoramTests>
<skipIntegrationTests>false</skipIntegrationTests>
<skipIsolatedIntegrationTests>false</skipIsolatedIntegrationTests>
- <skipCompatibilityTests>false</skipCompatibilityTests>
Review Comment:
You left it set not-skipped/enabled in the fast-tests profile.
##########
pom.xml:
##########
@@ -1287,6 +1286,12 @@
<skipLeakTests>false</skipLeakTests>
</properties>
</profile>
+ <profile>
+ <id>compatibility-tests</id>
Review Comment:
Would prefer this profile was in the compatibility-tests module.
Well, it is already there...would prefer the property was redefined in the
module.
Issue Time Tracking
-------------------
Worklog Id: (was: 870650)
Time Spent: 2.5h (was: 2h 20m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> ----------------------------------------------------------
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
