[
https://issues.apache.org/jira/browse/ARTEMIS-4360?focusedWorklogId=870621&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870621
]
ASF GitHub Bot logged work on ARTEMIS-4360:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/23 14:42
Start Date: 12/Jul/23 14:42
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4551:
URL: https://github.com/apache/activemq-artemis/pull/4551#discussion_r1261286699
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/base/ClasspathBase.java:
##########
@@ -181,7 +179,15 @@ protected ClassLoader getClasspath(String name, boolean
forceNew) throws Excepti
classPathValue = buffer.toString();
}
- Assert.assertTrue("Cannot run compatibility tests, no classpath found on
./target/" + name + ".cp", classPathValue != null &&
!classPathValue.trim().equals(""));
+ boolean foundClassPath = classPathValue != null &&
!classPathValue.trim().equals("");
+
+ if (!foundClassPath) {
+ logger.info("Rebuild project with -Pcompatibility-tests. Cannot find
classpath definition for {}", name);
+ }
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests.",
foundClassPath);
+
+ Assume.assumeTrue("Rebuild project with -Pcompatibility-tests to be able
to run this test. No classpath found on ./target/" + name + ".cp",
foundClassPath);
Review Comment:
@gemmellr I used to use assume before I switched to files. The idea was that
if the variable wasn't set, the test for that particular class path would just
be ignored.
I thought it would still be valid to have the tests running at least on the
snapshots as that would at least validate the test itself.. but I can just
disable it altogether if the profile is not run and keep as before. which I
will do.
Issue Time Tracking
-------------------
Worklog Id: (was: 870621)
Time Spent: 1h 50m (was: 1h 40m)
> Make compatibility-tests opt in with -Pcompatibility-tests
> ----------------------------------------------------------
>
> Key: ARTEMIS-4360
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4360
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.30.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> we should make compatibility-tests opt-in. from now on you have to use
> -Pcompatibility-tests to run them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
