[
https://issues.apache.org/jira/browse/ARTEMIS-4510?focusedWorklogId=909905&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909905
]
ASF GitHub Bot logged work on ARTEMIS-4510:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/24 14:39
Start Date: 14/Mar/24 14:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1524997952
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1835,6 +1856,8 @@ public void encode(ActiveMQBuffer buffer) {
BufferHelper.writeNullableInteger(buffer, prefetchPageBytes);
BufferHelper.writeNullableInteger(buffer, prefetchPageMessages);
+
+ BufferHelper.writeNullableBoolean(buffer, autoCreateDivertDestination);
Review Comment:
@AntonRoskvist Can you add your change and rebase your PR on top of
https://github.com/apache/activemq-artemis/pull/4854
The tests were still using the old method. I am removing *any* usage from
the AddressSettings usage, and I am now making it *clearer* with a big javadoc
to not have any more additions.
The reason that you needed to add a field now was a reason I added the JSON
format. I got tired to see that method's wire being changed over time. That
got even worse when I played with my private branches when I was only bringing
the newer field and not the previous field.
So, if I added field A and B on apache/master
and only Brough field B to a private branch, my wire would be inconsistent
with apache/main. It was being clusterFreak to manage it :)
If you could bring my commit to your PR (Rebase as I said), and bring any
changes you like, it should now work.
Issue Time Tracking
-------------------
Worklog Id: (was: 909905)
Time Spent: 2h 20m (was: 2h 10m)
> Add auto-create-destination logic to diverts
> --------------------------------------------
>
> Key: ARTEMIS-4510
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4510
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Anton Roskvist
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This enables the use of dynamic routing decisions within the transformer by
> setting the message address. It also covers for a rare problem where if any
> of the forwarding addresses are removed during runtime, such as from
> auto-delete, the message would get silently dropped.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
