[ 
https://issues.apache.org/jira/browse/ARTEMIS-4510?focusedWorklogId=909954&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909954
 ]

ASF GitHub Bot logged work on ARTEMIS-4510:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/24 17:43
            Start Date: 14/Mar/24 17:43
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4681:
URL: https://github.com/apache/activemq-artemis/pull/4681#discussion_r1525279265


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/settings/impl/AddressSettings.java:
##########
@@ -1835,6 +1856,8 @@ public void encode(ActiveMQBuffer buffer) {
       BufferHelper.writeNullableInteger(buffer, prefetchPageBytes);
 
       BufferHelper.writeNullableInteger(buffer, prefetchPageMessages);
+
+      BufferHelper.writeNullableBoolean(buffer, autoCreateDivertDestination);

Review Comment:
   @AntonRoskvist I have merged #4854... if you rebase against main, you can 
add anything to the tests you mentioned and it should work now.
   
   I have removed any usage of the older encoder.. just keeping the decoder for 
compatibility with older journals.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 909954)
    Time Spent: 2.5h  (was: 2h 20m)

> Add auto-create-destination logic to diverts
> --------------------------------------------
>
>                 Key: ARTEMIS-4510
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4510
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Anton Roskvist
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> This enables the use of dynamic routing decisions within the transformer by 
> setting the message address. It also covers for a rare problem where if any 
> of the forwarding addresses are removed during runtime, such as from 
> auto-delete, the message would get silently dropped.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to