[
https://issues.apache.org/jira/browse/ARTEMIS-5090?focusedWorklogId=937252&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937252
]
ASF GitHub Bot logged work on ARTEMIS-5090:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/24 14:32
Start Date: 09/Oct/24 14:32
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5288:
URL: https://github.com/apache/activemq-artemis/pull/5288#discussion_r1793641001
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2550,6 +2552,11 @@ public boolean isExpirationRedundant() {
return true;
}
+ if (isInternalQueue() && name.toString().startsWith(MIRROR_ADDRESS)) {
+ logger.trace("Mirrored queues are not supposed to expiry. Address={},
Queue={}", address, name);
Review Comment:
I was doing it for everything internal.. but a test failed.. and a previous
JIRA asking exactly that behavior from the internal queue.. so I changed the
implementation to deal with only Mirror.
I just changed the title and commit name.. thanks
Issue Time Tracking
-------------------
Worklog Id: (was: 937252)
Time Spent: 0.5h (was: 20m)
> MirrorSNF IS not supposed to expiry messages
> --------------------------------------------
>
> Key: ARTEMIS-5090
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5090
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
