[ 
https://issues.apache.org/jira/browse/ARTEMIS-5090?focusedWorklogId=937261&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937261
 ]

ASF GitHub Bot logged work on ARTEMIS-5090:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/24 15:12
            Start Date: 09/Oct/24 15:12
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on PR #5288:
URL: 
https://github.com/apache/activemq-artemis/pull/5288#issuecomment-2402620940

   I don't see it touching the SnF queue at all, can you point me to it? I do 
see it looking at the expiry queue and checking X messages expire. X messages 
that were in the origin queue.
   
   My point is that for all the test knows, I break the mirroring again 5 
minutes after it i merged, such that we do expire SnF queue messages again, but 
only such that they get _discarded_ rather than routed to the expiry queue. 
That test will not notice that and so will still pass, but as a test 
specifically verifying the mirroring isnt expiring SnF queue messages it really 
should fail. Setting up a peer to verify the actual mirroring, verifies that it 
actually does what we expect. That will absolutely notice when it doesnt do it.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 937261)
    Time Spent: 1.5h  (was: 1h 20m)

> MirrorSNF IS not supposed to expiry messages
> --------------------------------------------
>
>                 Key: ARTEMIS-5090
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5090
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.37.0
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.38.0
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to