[ 
https://issues.apache.org/jira/browse/ARTEMIS-5090?focusedWorklogId=937270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937270
 ]

ASF GitHub Bot logged work on ARTEMIS-5090:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Oct/24 15:26
            Start Date: 09/Oct/24 15:26
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #5288:
URL: https://github.com/apache/activemq-artemis/pull/5288#discussion_r1793731288


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -2550,6 +2552,11 @@ public boolean isExpirationRedundant() {
          return true;
       }
 
+      if (isInternalQueue() && name.toString().startsWith(MIRROR_ADDRESS)) {
+         logger.trace("Mirror SNF queues are not suppsoed to expiry messages. 
Address={}, Queue={}", address, name);

Review Comment:
   ```suggestion
            logger.trace("Mirror SNF queues are not supposed to expire 
messages. Address={}, Queue={}", address, name);
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 937270)
    Time Spent: 2h  (was: 1h 50m)

> MirrorSNF IS not supposed to expiry messages
> --------------------------------------------
>
>                 Key: ARTEMIS-5090
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5090
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.37.0
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.38.0
>
>          Time Spent: 2h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to