[
https://issues.apache.org/jira/browse/ARTEMIS-5090?focusedWorklogId=937262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937262
]
ASF GitHub Bot logged work on ARTEMIS-5090:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/24 15:12
Start Date: 09/Oct/24 15:12
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5288:
URL: https://github.com/apache/activemq-artemis/pull/5288#discussion_r1793710442
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/AMQPMirrorExpiryQueueTest.java:
##########
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq.artemis.tests.integration.amqp.connect;
+
+import javax.jms.Connection;
+import javax.jms.ConnectionFactory;
+import javax.jms.MessageProducer;
+import javax.jms.Session;
+import java.lang.invoke.MethodHandles;
+import java.util.HashMap;
+
+import org.apache.activemq.artemis.api.core.QueueConfiguration;
+import org.apache.activemq.artemis.api.core.RoutingType;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.api.core.TransportConfiguration;
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPBrokerConnectConfiguration;
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPBrokerConnectionAddressType;
+import
org.apache.activemq.artemis.core.config.amqpBrokerConnectivity.AMQPMirrorBrokerConnectionElement;
+import org.apache.activemq.artemis.core.remoting.impl.netty.TransportConstants;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import org.apache.activemq.artemis.core.server.Queue;
+import org.apache.activemq.artemis.core.settings.impl.AddressSettings;
+import org.apache.activemq.artemis.tests.util.ActiveMQTestBase;
+import org.apache.activemq.artemis.tests.util.CFUtil;
+import org.apache.activemq.artemis.tests.util.RandomUtil;
+import org.apache.activemq.artemis.tests.util.Wait;
+import org.junit.jupiter.api.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class AMQPMirrorExpiryQueueTest extends ActiveMQTestBase {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private static final String EXPIRY_QUEUE = "ExpiryOut";
+
+ protected TransportConfiguration newAcceptorConfig(int port, String name) {
+ HashMap<String, Object> params = new HashMap<>();
+ params.put(TransportConstants.PORT_PROP_NAME, String.valueOf(port));
+ params.put(TransportConstants.PROTOCOLS_PROP_NAME, "AMQP,CORE,OPENWIRE");
+ HashMap<String, Object> amqpParams = new HashMap<>();
+ TransportConfiguration tc = new
TransportConfiguration(NETTY_ACCEPTOR_FACTORY, params, name, amqpParams);
+ return tc;
+ }
+
+ protected ActiveMQServer createServer(int port, String brokerName) throws
Exception {
+
+ final ActiveMQServer server = this.createServer(true, true);
+
+ server.getConfiguration().getAcceptorConfigurations().clear();
+
server.getConfiguration().getAcceptorConfigurations().add(newAcceptorConfig(port,
"netty-acceptor"));
+ server.getConfiguration().setName(brokerName);
+
server.getConfiguration().setJournalDirectory(server.getConfiguration().getJournalDirectory()
+ port);
+
server.getConfiguration().setBindingsDirectory(server.getConfiguration().getBindingsDirectory()
+ port);
+
server.getConfiguration().setPagingDirectory(server.getConfiguration().getPagingDirectory()
+ port);
+ server.getConfiguration().setJMXManagementEnabled(true);
+ server.getConfiguration().setMessageExpiryScanPeriod(100);
+ server.getConfiguration().setMessageExpiryScanPeriod(5);
+
+ server.getConfiguration().addAddressSetting("#", new
AddressSettings().setExpiryAddress(SimpleString.of(EXPIRY_QUEUE)));
+ return server;
+ }
+
+ @Test
+ public void testExpiryOnMirrorSNF() throws Exception {
+
+ final long numberOfMessages = 10;
+ ActiveMQServer serverA = createServer(5671, "serverA");
+ ActiveMQServer serverB = createServer(6671, "serverB");
+
+ {
+ AMQPBrokerConnectConfiguration amqpConnection = new
AMQPBrokerConnectConfiguration("A_to_B",
"tcp://localhost:6671").setReconnectAttempts(-1).setRetryInterval(10);
+ AMQPMirrorBrokerConnectionElement replica = new
AMQPMirrorBrokerConnectionElement().setType(AMQPBrokerConnectionAddressType.MIRROR).setDurable(true);
+ amqpConnection.addElement(replica);
+ serverA.getConfiguration().addAMQPConnection(amqpConnection);
+ }
+
+ {
+ AMQPBrokerConnectConfiguration amqpConnection = new
AMQPBrokerConnectConfiguration("B_to_A",
"tcp://localhost:5671").setReconnectAttempts(-1).setRetryInterval(10);
+ AMQPMirrorBrokerConnectionElement replica = new
AMQPMirrorBrokerConnectionElement().setType(AMQPBrokerConnectionAddressType.MIRROR).setDurable(true);
+ amqpConnection.addElement(replica);
+ serverB.getConfiguration().addAMQPConnection(amqpConnection);
+ }
+
+ String queueName = "queue" + RandomUtil.randomString();
Review Comment:
not sure why you resolve this?
Issue Time Tracking
-------------------
Worklog Id: (was: 937262)
Time Spent: 1h 40m (was: 1.5h)
> MirrorSNF IS not supposed to expiry messages
> --------------------------------------------
>
> Key: ARTEMIS-5090
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5090
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
