[
https://issues.apache.org/jira/browse/ARTEMIS-5093?focusedWorklogId=937479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937479
]
ASF GitHub Bot logged work on ARTEMIS-5093:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Oct/24 20:39
Start Date: 10/Oct/24 20:39
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5291:
URL: https://github.com/apache/activemq-artemis/pull/5291#discussion_r1796067224
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java:
##########
@@ -1298,6 +1298,18 @@ public ServerLocatorImpl
setInitialMessagePacketSize(final int size) {
return this;
}
+ @Override
+ public int getOnMessageCloseTimeout() {
+ return config.onMessageCloseTimeout;
+ }
+
+ @Override
Review Comment:
The API docs specify the value set must be greater than zero, but there
isn't any validation of that, should there be?
Issue Time Tracking
-------------------
Worklog Id: (was: 937479)
Time Spent: 20m (was: 10m)
> Support configurable onMessage timeout when closing consumer
> ------------------------------------------------------------
>
> Key: ARTEMIS-5093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5093
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When closing a consumer the Core client is hard-coded to wait for 10,000ms
> for any {{onMessage}} to complete. This timeout should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
