[
https://issues.apache.org/jira/browse/ARTEMIS-5093?focusedWorklogId=943776&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943776
]
ASF GitHub Bot logged work on ARTEMIS-5093:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Nov/24 11:31
Start Date: 14/Nov/24 11:31
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5291:
URL: https://github.com/apache/activemq-artemis/pull/5291#discussion_r1842066411
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java:
##########
@@ -1298,6 +1298,18 @@ public ServerLocatorImpl
setInitialMessagePacketSize(final int size) {
return this;
}
+ @Override
+ public int getOnMessageCloseTimeout() {
+ return config.onMessageCloseTimeout;
+ }
+
+ @Override
Review Comment:
It would seem weird to configure those if actually knowing thats what it
then does, but I'd guess some might think one of those would simply mean _keep
waiting_ (e.g as is the described behaviour in the JMS spec, albeit that also
originally described to effectively deadlock yourself as result hehe),
especially if not reading the javadoc (should there also be actual-docs
addition?).
Issue Time Tracking
-------------------
Worklog Id: (was: 943776)
Time Spent: 1h 10m (was: 1h)
> Support configurable onMessage timeout when closing consumer
> ------------------------------------------------------------
>
> Key: ARTEMIS-5093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5093
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When closing a consumer the Core client is hard-coded to wait for 10,000ms
> for any {{onMessage}} to complete. This timeout should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
