[
https://issues.apache.org/jira/browse/ARTEMIS-5093?focusedWorklogId=938501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-938501
]
ASF GitHub Bot logged work on ARTEMIS-5093:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Oct/24 19:58
Start Date: 16/Oct/24 19:58
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5291:
URL: https://github.com/apache/activemq-artemis/pull/5291#discussion_r1803723419
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ServerLocatorImpl.java:
##########
@@ -1298,6 +1298,18 @@ public ServerLocatorImpl
setInitialMessagePacketSize(final int size) {
return this;
}
+ @Override
+ public int getOnMessageCloseTimeout() {
+ return config.onMessageCloseTimeout;
+ }
+
+ @Override
Review Comment:
I did look into what it does with that configuration value and since it is
passing into a CountdownLatch is seems like it will not trigger an exception
but will return immediately so from the standpoint of being able to be set to
zero or negative it works, although seems an absurd value to assign.
Issue Time Tracking
-------------------
Worklog Id: (was: 938501)
Time Spent: 40m (was: 0.5h)
> Support configurable onMessage timeout when closing consumer
> ------------------------------------------------------------
>
> Key: ARTEMIS-5093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5093
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When closing a consumer the Core client is hard-coded to wait for 10,000ms
> for any {{onMessage}} to complete. This timeout should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
