[
https://issues.apache.org/jira/browse/ARTEMIS-5093?focusedWorklogId=944690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944690
]
ASF GitHub Bot logged work on ARTEMIS-5093:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/24 20:21
Start Date: 20/Nov/24 20:21
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5291:
URL: https://github.com/apache/activemq-artemis/pull/5291#discussion_r1850934492
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientConsumerImpl.java:
##########
@@ -911,10 +916,10 @@ private void waitForOnMessageToComplete(boolean
waitForOnMessage) {
sessionExecutor.execute(future);
- boolean ok = future.await(ClientConsumerImpl.CLOSE_TIMEOUT_MILLISECONDS);
+ boolean ok = future.await(onMessageCloseTimeout);
Review Comment:
No, it is not still required.
Issue Time Tracking
-------------------
Worklog Id: (was: 944690)
Time Spent: 1.5h (was: 1h 20m)
> Support configurable onMessage timeout when closing consumer
> ------------------------------------------------------------
>
> Key: ARTEMIS-5093
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5093
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When closing a consumer the Core client is hard-coded to wait for 10,000ms
> for any {{onMessage}} to complete. This timeout should be configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
