[
https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218553#comment-16218553
]
ASF GitHub Bot commented on ARROW-1723:
---------------------------------------
JohnPJenkins commented on issue #1244: ARROW-1723: [C++] add ARROW_STATIC to
mark static libs on Windows
URL: https://github.com/apache/arrow/pull/1244#issuecomment-339319781
Some info on WINDOWS_EXPORT_ALL_SYMBOLS:
https://cmake.org/cmake/help/latest/prop_tgt/WINDOWS_EXPORT_ALL_SYMBOLS.html.
Would certainly eliminate the need for marking up classes/functions, but as you
note exported data symbols will still need it. Snappy doesn't appear to have
any from a cursory look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
> Key: ARROW-1723
> URL: https://issues.apache.org/jira/browse/ARROW-1723
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: John Jenkins
> Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and
> using static libraries on Windows. A PR will follow shortly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
