[
https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218627#comment-16218627
]
ASF GitHub Bot commented on ARROW-1723:
---------------------------------------
MaxRis commented on issue #1244: ARROW-1723: [C++] add ARROW_STATIC to mark
static libs on Windows
URL: https://github.com/apache/arrow/pull/1244#issuecomment-339330749
@wesm some [more reading on what it takes to use
WINDOWS_EXPORT_ALL_SYMBOL](https://blog.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/)
(in the bottom of article)
We might try to use it, but it might be not a good thing to rely on feature
in CMake and to not have compatibility with any other build tools on Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
> Key: ARROW-1723
> URL: https://issues.apache.org/jira/browse/ARROW-1723
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: John Jenkins
> Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and
> using static libraries on Windows. A PR will follow shortly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
