[ 
https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218645#comment-16218645
 ] 

ASF GitHub Bot commented on ARROW-1723:
---------------------------------------

wesm commented on issue #1244: ARROW-1723: [C++] add ARROW_STATIC to mark 
static libs on Windows
URL: https://github.com/apache/arrow/pull/1244#issuecomment-339333354
 
 
   @MaxRis yeah, I agree on that. In case we support other build systems (like 
Bazel) in the future it would be better to have the exports explicit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
>                 Key: ARROW-1723
>                 URL: https://issues.apache.org/jira/browse/ARROW-1723
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: John Jenkins
>              Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and 
> using static libraries on Windows. A PR will follow shortly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to