[
https://issues.apache.org/jira/browse/ARROW-1723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218578#comment-16218578
]
ASF GitHub Bot commented on ARROW-1723:
---------------------------------------
JohnPJenkins commented on a change in pull request #1244: ARROW-1723: [C++] add
ARROW_STATIC to mark static libs on Windows
URL: https://github.com/apache/arrow/pull/1244#discussion_r146848645
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -165,6 +165,8 @@ function(ADD_ARROW_LIB LIB_NAME)
LIBRARY_OUTPUT_DIRECTORY "${BUILD_OUTPUT_ROOT_DIRECTORY}"
OUTPUT_NAME ${LIB_NAME_STATIC})
+ target_compile_definitions(${LIB_NAME}_static PUBLIC ARROW_STATIC)
Review comment:
You're right, I missed that one - this patch won't work then when building
both libraries. Perhaps I should update the PR to build separate object
libraries for the shared and static variants?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Windows: __declspec(dllexport) specified when building arrow static library
> ---------------------------------------------------------------------------
>
> Key: ARROW-1723
> URL: https://issues.apache.org/jira/browse/ARROW-1723
> Project: Apache Arrow
> Issue Type: Bug
> Components: C++
> Reporter: John Jenkins
> Labels: pull-request-available
>
> As I understand it, dllexport/dllimport should be left out when building and
> using static libraries on Windows. A PR will follow shortly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
