[ 
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251597#comment-16251597
 ] 

ASF GitHub Bot commented on ARROW-1476:
---------------------------------------

icexelloss commented on issue #1316: ARROW-1476: [JAVA] Implement Final 
ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#issuecomment-344302566
 
 
   @siddharthteotia This looks good. I left some comments.
   
   One thing is that it seems this patch has quite bit of bug fixes but not 
many new tests. Should we add tests for those bug fixes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
>                 Key: ARROW-1476
>                 URL: https://issues.apache.org/jira/browse/ARROW-1476
>             Project: Apache Arrow
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>            Assignee: Siddharth Teotia
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to