[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251879#comment-16251879
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
siddharthteotia commented on a change in pull request #1316: ARROW-1476: [JAVA]
Implement Final ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#discussion_r150919304
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/NullableBitVector.java
##########
@@ -163,7 +163,7 @@ private ArrowBuf splitAndTransferBuffer(int startIndex,
int length,
if (destBuffer != null) {
destBuffer.release();
}
- destBuffer = destBuffer.slice(firstByteSource, byteSizeTarget);
Review comment:
Yes, we have unit tests for splitAndTransfer of bit vector (validity
buffer). Also we have unit tests for split and transfer of other vectors
(nullable fixed, var width and complex) and we exercise all the conditions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
