[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251876#comment-16251876
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
siddharthteotia commented on a change in pull request #1316: ARROW-1476: [JAVA]
Implement Final ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#discussion_r150918786
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/BaseNullableVariableWidthVector.java
##########
@@ -836,17 +858,259 @@ public int getLastSet() {
* @return starting offset for the element
*/
public long getStartEnd(int index) {
- return (long)offsetBuffer.getInt(index * OFFSET_WIDTH);
+ return offsetBuffer.getLong(index * OFFSET_WIDTH);
}
/**
* Mark the particular position in the vector as non-null.
*
* @param index position of the element.
*/
+ @Override
public void setIndexDefined(int index) {
Review comment:
Not quite sure. Since this has always been setIndexDefined(), I just left it
as is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
