[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251899#comment-16251899
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
siddharthteotia commented on a change in pull request #1316: ARROW-1476: [JAVA]
Implement Final ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#discussion_r150921220
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/NullableBitVector.java
##########
@@ -279,6 +279,8 @@ public Boolean getObject(int index) {
public void copyFrom(int fromIndex, int thisIndex, NullableBitVector from) {
if (from.isSet(fromIndex) != 0) {
set(thisIndex, from.get(fromIndex));
+ } else {
+ BitVectorHelper.setValidityBit(validityBuffer, thisIndex, 0);
Review comment:
We have some copy() related unit tests but in any case, I am planning to
write more unit tests in the next couple of weeks to get overall good coverage.
I don't think so I can get to them now because of time constraints.
Note that behavior of copyFrom() hasn't changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
