[
https://issues.apache.org/jira/browse/ARROW-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261205#comment-16261205
]
ASF GitHub Bot commented on ARROW-1832:
---------------------------------------
TheNeuralBit commented on issue #1343: [WIP] ARROW-1832: [JS] Implement JSON
reader for integration tests
URL: https://github.com/apache/arrow/pull/1343#issuecomment-346114553
@trxcllnt I seem to have broken the closure compiler build by adding
`src/format/arrow.ts` - any idea what's wrong?
Also, I'm interested in your feedback on some of the re-structuring I did. I
made a [`FieldBuilder` and
`FieldNodeBuilder`](https://github.com/apache/arrow/pull/1343/commits/4e9767aca59fe471e62c3b770f3946d51eab2012#diff-b4be157e615dd41b8b50ad1c6021e506R26)
which replicate the flatbuffers `Field` and `FieldNode` interfaces, and then I
made the `fieldMixin` constructor accept [either
type](https://github.com/apache/arrow/pull/1343/commits/4e9767aca59fe471e62c3b770f3946d51eab2012#diff-7ae84ba988036361542a685bcd1d672dR22).
That way I can create "field" vectors from the JSON reader without building
flatbuffers objects.
I thought something like this may be useful for a writer in the future,
which is why I went ahead and stubbed out some [write()
methods](https://github.com/apache/arrow/pull/1343/commits/4e9767aca59fe471e62c3b770f3946d51eab2012#diff-b4be157e615dd41b8b50ad1c6021e506R43).
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Implement JSON reader for integration tests
> ------------------------------------------------
>
> Key: ARROW-1832
> URL: https://issues.apache.org/jira/browse/ARROW-1832
> Project: Apache Arrow
> Issue Type: New Feature
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Labels: pull-request-available
>
> Implementing a JSON reader will allow us to write a "validate" script for the
> consumer half of the integration tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
