[
https://issues.apache.org/jira/browse/ARROW-1832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16261470#comment-16261470
]
ASF GitHub Bot commented on ARROW-1832:
---------------------------------------
trxcllnt commented on issue #1343: [WIP] ARROW-1832: [JS] Implement JSON reader
for integration tests
URL: https://github.com/apache/arrow/pull/1343#issuecomment-346124815
@theneuralbit awesome! Will look closer when I’m on my laptop. To fix the
closure build issue, just update [lines 55 and
58](https://github.com/apache/arrow/blob/master/js/gulp/typescript-task.js#L55)
to the new generated JS files glob path.
It’s hacky, but cc with advanced opts can’t track the property names through
the nested function declaration IEFE’s that TS compiles namespaces to while
mangling, so we use the flatc generated JS files here instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Implement JSON reader for integration tests
> ------------------------------------------------
>
> Key: ARROW-1832
> URL: https://issues.apache.org/jira/browse/ARROW-1832
> Project: Apache Arrow
> Issue Type: New Feature
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Labels: pull-request-available
>
> Implementing a JSON reader will allow us to write a "validate" script for the
> consumer half of the integration tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
