[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270033#comment-16270033
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
BryanCutler commented on a change in pull request #1371: [WIP] ARROW-1866:
[Java] Combine MapVector classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#discussion_r153683695
##########
File path:
java/vector/src/test/java/org/apache/arrow/vector/complex/writer/TestComplexWriter.java
##########
@@ -849,11 +848,12 @@ public void testSingleMapWriter1() {
/* initialize a SingleMapWriter with empty MapVector and then lazily
* create all vectors with expected initialCapacity.
*/
- NonNullableMapVector parent = NonNullableMapVector.empty("parent",
allocator);
+ MapVector parent = MapVector.empty("parent", allocator);
SingleMapWriter singleMapWriter = new SingleMapWriter(parent);
int initialCapacity = 1024;
singleMapWriter.setInitialCapacity(initialCapacity);
+ singleMapWriter.allocate();
Review comment:
now need to make sure the validity buffer is allocated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
