[ 
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271382#comment-16271382
 ] 

ASF GitHub Bot commented on ARROW-1866:
---------------------------------------

icexelloss commented on issue #1371: [WIP] ARROW-1866: [Java] Combine MapVector 
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-347966543
 
 
   > I could also remove the codegen file MapWriters.java and just have one non 
codegen class MapWriter
   
   I think we probably still need to codegen the MapWriter class because it 
codegen methods for different types. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
>                 Key: ARROW-1866
>                 URL: https://issues.apache.org/jira/browse/ARROW-1866
>             Project: Apache Arrow
>          Issue Type: Sub-task
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed 
> as part of removing the non nullable vectors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to