[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271369#comment-16271369
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
BryanCutler commented on a change in pull request #1371: [WIP] ARROW-1866:
[Java] Combine MapVector classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#discussion_r153885958
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/MapVector.java
##########
@@ -116,6 +137,19 @@ private void setReaderAndWriterIndex() {
throw new UnsupportedOperationException("There are no inner vectors. Use
getFieldBuffers");
}
+ @Override
+ protected boolean supportsDirectRead() {
Review comment:
Not sure, it was in `NonNullableMapVector` so I brought it over. This
doesn't seem to be used anywhere and overrides from `AbstractContainerVector`
that returns false. @siddharthteotia do you know what this was used for and if
it is still needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
