[ 
https://issues.apache.org/jira/browse/ARROW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16378757#comment-16378757
 ] 

ASF GitHub Bot commented on ARROW-2226:
---------------------------------------

TheNeuralBit commented on issue #1671: ARROW-2226: [JS] use indicies.offset in 
DictionaryData constructor
URL: https://github.com/apache/arrow/pull/1671#issuecomment-368913793
 
 
   How does this bug present itself? I thought maybe `DictionaryVector.slice` 
wouldn't work, but I just wrote some unit tests for that on master and it seems 
ok

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [JS] DictionaryData should use indices' offset in constructor
> -------------------------------------------------------------
>
>                 Key: ARROW-2226
>                 URL: https://issues.apache.org/jira/browse/ARROW-2226
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>    Affects Versions: JS-0.3.0
>            Reporter: Paul Taylor
>            Assignee: Paul Taylor
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to