[
https://issues.apache.org/jira/browse/ARROW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379170#comment-16379170
]
ASF GitHub Bot commented on ARROW-2226:
---------------------------------------
trxcllnt commented on issue #1671: ARROW-2226: [JS] use indices.offset in
DictionaryData constructor
URL: https://github.com/apache/arrow/pull/1671#issuecomment-368999720
@wesm @TheNeuralBit yeah, I wanted to get a fix in first. I encountered this
trying to read values from a DictionaryVector whose indices have a `nullCount >
0`. I think this was just a typo/bad merge when I merged my branch with Brian's
a few weeks ago. I would imagine the Dictionary integration tests could cover
this case?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] DictionaryData should use indices' offset in constructor
> -------------------------------------------------------------
>
> Key: ARROW-2226
> URL: https://issues.apache.org/jira/browse/ARROW-2226
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: JS-0.3.0
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)