[ 
https://issues.apache.org/jira/browse/ARROW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16380372#comment-16380372
 ] 

ASF GitHub Bot commented on ARROW-2226:
---------------------------------------

TheNeuralBit commented on issue #1671: ARROW-2226: [JS] use indices.offset in 
DictionaryData constructor
URL: https://github.com/apache/arrow/pull/1671#issuecomment-369254512
 
 
   I already started adding some basic unit tests for DictionaryVector, so I'll 
look at adding a test that covers the indices `nullCount > 0` case and maybe PR 
them into your branch @trxcllnt 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JS] DictionaryData should use indices' offset in constructor
> -------------------------------------------------------------
>
>                 Key: ARROW-2226
>                 URL: https://issues.apache.org/jira/browse/ARROW-2226
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>    Affects Versions: JS-0.3.0
>            Reporter: Paul Taylor
>            Assignee: Paul Taylor
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to