[ 
https://issues.apache.org/jira/browse/ARROW-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379194#comment-16379194
 ] 

ASF GitHub Bot commented on ARROW-2226:
---------------------------------------

trxcllnt commented on issue #1671: ARROW-2226: [JS] use indices.offset in 
DictionaryData constructor
URL: https://github.com/apache/arrow/pull/1671#issuecomment-369005827
 
 
   @wesm I might've asked this before, but is it possible (via the spec) for 
the `indices` itself to be a DictionaryVector (e.g. for mapping between an 
original to sorted set of indices)? We don't guard against doing it on-the-fly, 
but if we want to support it, we should probably go through the public 
`indicies.nullCount` instead of using the private `_nullCount` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JS] DictionaryData should use indices' offset in constructor
> -------------------------------------------------------------
>
>                 Key: ARROW-2226
>                 URL: https://issues.apache.org/jira/browse/ARROW-2226
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: JavaScript
>    Affects Versions: JS-0.3.0
>            Reporter: Paul Taylor
>            Assignee: Paul Taylor
>            Priority: Major
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to