[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1019410&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1019410
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/26 16:24
Start Date: 08/May/26 16:24
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3209954369
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessageMapCodec.java:
##########
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.protocol.amqp.broker;
+
+import java.lang.invoke.MethodHandles;
+
+import org.apache.activemq.artemis.api.core.ActiveMQBuffer;
+import org.apache.activemq.artemis.api.core.Message;
+import org.apache.activemq.artemis.api.core.SimpleString;
+import org.apache.activemq.artemis.utils.collections.MapCodec;
+import org.apache.activemq.artemis.utils.collections.TypedProperties;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Encodes AMQP messages for storage using a hashmap-like encoding. It is used
by {@link AMQPLargeMessagePersisterV2} and {@link AMQPMessagePersisterV4}. */
+public class AMQPMessageMapCodec extends MapCodec {
+
+ private static final Logger logger =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+ private static final ThreadLocal<AMQPMessageMapCodec> threadLocal =
ThreadLocal.withInitial(AMQPMessageMapCodec::new);
+
+ public static AMQPMessageMapCodec getInstance() {
+ AMQPMessageMapCodec reader = threadLocal.get();
+ return reader;
+ }
Review Comment:
@gemmellr I can do that. although I'm using a thread local now because of
the state I needed to store before creating a message.
There's one changed I wanted to make on the constructors for
AMQPStandardMessage and AMQPLargeMessage, that I could keep the implementation
stateless, and just post data directly on the message. then I wouldn't need a
ThreadLocal and I could just work with the message directly.
Issue Time Tracking
-------------------
Worklog Id: (was: 1019410)
Time Spent: 14h 10m (was: 14h)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 14h 10m
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
