[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1015994&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1015994
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/26 16:52
Start Date: 16/Apr/26 16:52
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3094906489
##########
tests/compatibility-tests/src/test/java/org/apache/activemq/artemis/tests/compatibility/MultiVersionReplicaTest.java:
##########
@@ -63,13 +64,11 @@ public static Collection getParameters() {
if (getJavaVersion() <= 22) {
// Old 2.x servers fail on JDK23+ without workarounds.
combinations.add(new Object[]{ARTEMIS_2_22_0, SNAPSHOT});
- combinations.add(new Object[]{SNAPSHOT, ARTEMIS_2_22_0});
combinations.add(new Object[]{ARTEMIS_2_17_0, SNAPSHOT});
- combinations.add(new Object[]{SNAPSHOT, ARTEMIS_2_17_0});
+ combinations.add(new Object[]{ARTEMIS_2_33_0, SNAPSHOT});
}
combinations.add(new Object[]{ARTEMIS_2_44_0, SNAPSHOT});
- combinations.add(new Object[]{SNAPSHOT, ARTEMIS_2_44_0});
Review Comment:
version compatibility support is alwasys forward . the backward
compatibility is best effort.. and this case the journal persistence is broken
by V4. the older version won't understand V4.
Issue Time Tracking
-------------------
Worklog Id: (was: 1015994)
Time Spent: 13h (was: 12h 50m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 13h
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
