[
https://issues.apache.org/jira/browse/ARTEMIS-5573?focusedWorklogId=1019412&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1019412
]
ASF GitHub Bot logged work on ARTEMIS-5573:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/May/26 16:26
Start Date: 08/May/26 16:26
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6323:
URL: https://github.com/apache/artemis/pull/6323#discussion_r3209965028
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/CoreRemotingConnection.java:
##########
@@ -81,6 +81,11 @@ default boolean isBeforeProducerMetricsChanged() {
return version < PacketImpl.ARTEMIS_2_28_0_VERSION;
}
+ default boolean isBeforeAMQPMapCodecChanged() {
Review Comment:
isBeforeAMQPPersistenceMapUpdate would be a good name?
Issue Time Tracking
-------------------
Worklog Id: (was: 1019412)
Time Spent: 14.5h (was: 14h 20m)
> Make AMQP Size immutable
> ------------------------
>
> Key: ARTEMIS-5573
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5573
> Project: Artemis
> Issue Type: Improvement
> Components: AMQP
> Affects Versions: 2.41.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> I have had a lot of issues, even recently on races between re-evaluating a
> message size in AMQP.
> Say a lazy decode happens at the wrong time and the memory estimates can be
> wrong.
> We have fixed issues along the years, but this is still a fragile process
> that is bound to fail. If an user for instance add a plugin breaking the
> chain of events.
> For that reason the memory estimate should already include enough estimation
> for any properties decoded and the process should be simplified.
> Less moving parts would mean less possibilities for bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
