[
https://issues.apache.org/jira/browse/BEAM-5804?focusedWorklogId=156543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-156543
]
ASF GitHub Bot logged work on BEAM-5804:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/18 16:14
Start Date: 20/Oct/18 16:14
Worklog Time Spent: 10m
Work Description: adude3141 opened a new pull request #6768: [BEAM-5804]
remove javacc bad option warning
URL: https://github.com/apache/beam/pull/6768
remove non existing option from Gradle task configuration
After downgrade to JavaCC 4.0 the option "grammar_enoding" does not yet exist
After downgrade to JavaCC 4.0 build complains about the not yet existing
option 'grammar_encoding' configured within build.gradle.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/)
| --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 156543)
Time Spent: 10m
Remaining Estimate: 0h
> Remove JavaCC bad option warning
> --------------------------------
>
> Key: BEAM-5804
> URL: https://issues.apache.org/jira/browse/BEAM-5804
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning
> {no format}
> $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc
> > Task :beam-sdks-java-extensions-sql:compileJavacc
> Java Compiler Compiler Version 4.0 (Parser Generator)
> (type "javacc" with no arguments for help)
> Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
> {no format}
> This is simply due to the fact, that this option does not yet exist in JavaCC
> 4.0 [2]
>
> So we probably should just remove this option.
> [1]https://issues.apache.org/jira/browse/BEAM-4233
> [2]https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
