[
https://issues.apache.org/jira/browse/BEAM-5804?focusedWorklogId=157136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157136
]
ASF GitHub Bot logged work on BEAM-5804:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 19:49
Start Date: 22/Oct/18 19:49
Worklog Time Spent: 10m
Work Description: adude3141 commented on issue #6768: [BEAM-5804] remove
javacc bad option warning
URL: https://github.com/apache/beam/pull/6768#issuecomment-431906708
@swegner
You are right about when this option was added. At that time, project was
configured to use a 'newer' version of JavaCC, which did support
'grammar_encoding'.
As far as this PR is concerned, it is about removing an option, which just
does not exist on javaCC (version 4.0). Currently, the build system 'pretends'
to be setting the grammars file encoding to UTF-8. Actually, JavaCC will ignore
that option and read with systems file encoding, (or what's set with
-Dfile.encoding), which might or might not happen to be set to UTF-8.
So, if it is required to set the grammars file encoding, we do need to find
another mechanism.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157136)
Time Spent: 1h 10m (was: 1h)
> Remove JavaCC bad option warning
> --------------------------------
>
> Key: BEAM-5804
> URL: https://issues.apache.org/jira/browse/BEAM-5804
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning
> {no format}
>
> $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc
>
> > Task :beam-sdks-java-extensions-sql:compileJavacc
>
> Java Compiler Compiler Version 4.0 (Parser Generator)
>
> (type "javacc" with no arguments for help)
>
> Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
> \{no format}
> This is simply due to the fact, that this option does not yet exist in JavaCC
> 4.0 [2]
>
> So we probably should just remove this option.
> [1] https://issues.apache.org/jira/browse/BEAM-4233
> [2]
> https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
