[
https://issues.apache.org/jira/browse/BEAM-5804?focusedWorklogId=157012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157012
]
ASF GitHub Bot logged work on BEAM-5804:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 19:26
Start Date: 22/Oct/18 19:26
Worklog Time Spent: 10m
Work Description: swegner commented on issue #6768: [BEAM-5804] remove
javacc bad option warning
URL: https://github.com/apache/beam/pull/6768#issuecomment-431875472
I'm not familiar with the context or history around this option. @adude3141
if you're familiar can you add some description in the commit / PR description?
It appears this config was added in the [initial Gradle migration
PR](https://github.com/apache/beam/pull/4096), specifically commit
6f55ccd2801a3d07b40c8efc43baff43e0e66b8e:
> Enable FFMP -> JavaCC path to generate Beam SQL parser for
sdks/java/extensions/sql
@lukecwik / @apilloud do you know if this is necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157012)
Time Spent: 50m (was: 40m)
> Remove JavaCC bad option warning
> --------------------------------
>
> Key: BEAM-5804
> URL: https://issues.apache.org/jira/browse/BEAM-5804
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning
> {no format}
>
> $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc
>
> > Task :beam-sdks-java-extensions-sql:compileJavacc
>
> Java Compiler Compiler Version 4.0 (Parser Generator)
>
> (type "javacc" with no arguments for help)
>
> Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
> \{no format}
> This is simply due to the fact, that this option does not yet exist in JavaCC
> 4.0 [2]
>
> So we probably should just remove this option.
> [1] https://issues.apache.org/jira/browse/BEAM-4233
> [2]
> https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
