[
https://issues.apache.org/jira/browse/BEAM-5804?focusedWorklogId=157215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-157215
]
ASF GitHub Bot logged work on BEAM-5804:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/18 21:40
Start Date: 22/Oct/18 21:40
Worklog Time Spent: 10m
Work Description: swegner closed pull request #6768: [BEAM-5804] remove
javacc bad option warning
URL: https://github.com/apache/beam/pull/6768
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/extensions/sql/build.gradle
b/sdks/java/extensions/sql/build.gradle
index 8eaf09cc05b..1b008bc49b1 100644
--- a/sdks/java/extensions/sql/build.gradle
+++ b/sdks/java/extensions/sql/build.gradle
@@ -123,7 +123,7 @@ compileJavacc {
dependsOn generateFmppSources
inputDirectory = file(generateFmppJavaccRoot)
outputDirectory = file(generatedJavaccPackageDir)
- arguments = [grammar_encoding: "UTF-8", static: "false", lookahead: "2"]
+ arguments = [static: "false", lookahead: "2"]
}
// Help IntelliJ find the fmpp bits
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 157215)
Time Spent: 1.5h (was: 1h 20m)
> Remove JavaCC bad option warning
> --------------------------------
>
> Key: BEAM-5804
> URL: https://issues.apache.org/jira/browse/BEAM-5804
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Michael Luckey
> Assignee: Michael Luckey
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> After the downgrade to JavaCC 4.0 [1], JavaCC compiler issues a warning
> {no format}
>
> $ ./gradlew -p sdks/java/extensions/sql cleanCompileJavacc compileJavacc
>
> > Task :beam-sdks-java-extensions-sql:compileJavacc
>
> Java Compiler Compiler Version 4.0 (Parser Generator)
>
> (type "javacc" with no arguments for help)
>
> Warning: Bad option "-grammar_encoding=UTF-8" will be ignored.
> \{no format}
> This is simply due to the fact, that this option does not yet exist in JavaCC
> 4.0 [2]
>
> So we probably should just remove this option.
> [1] https://issues.apache.org/jira/browse/BEAM-4233
> [2]
> https://github.com/javacc/javacc/blob/368da68784dca6b29dcf10043f056535b2c835a1/src/org/javacc/parser/Options.java#L93-L117
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
