[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=163570&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-163570
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Nov/18 18:30
Start Date: 07/Nov/18 18:30
Worklog Time Spent: 10m
Work Description: aaltay closed pull request #6975: [BEAM-5315] Always
write newline in bytes for textsink
URL: https://github.com/apache/beam/pull/6975
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/python/apache_beam/io/textio.py
b/sdks/python/apache_beam/io/textio.py
index f96a02ec8a2..73ab4a9deaa 100644
--- a/sdks/python/apache_beam/io/textio.py
+++ b/sdks/python/apache_beam/io/textio.py
@@ -383,7 +383,7 @@ def open(self, temp_path):
if self._header is not None:
file_handle.write(self._header)
if self._append_trailing_newlines:
- file_handle.write('\n')
+ file_handle.write(b'\n')
return file_handle
def display_data(self):
@@ -397,7 +397,7 @@ def write_encoded_record(self, file_handle, encoded_value):
"""Writes a single encoded record."""
file_handle.write(encoded_value)
if self._append_trailing_newlines:
- file_handle.write('\n')
+ file_handle.write(b'\n')
def _create_text_source(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 163570)
Time Spent: 5h 50m (was: 5h 40m)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
