[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=167774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-167774
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/18 15:09
Start Date: 20/Nov/18 15:09
Worklog Time Spent: 10m
Work Description: splovyt commented on a change in pull request #6925:
[BEAM-5315] Partially port IO: avro schema parsing and codecs
URL: https://github.com/apache/beam/pull/6925#discussion_r235039855
##########
File path: sdks/python/apache_beam/io/tfrecordio_test.py
##########
@@ -405,6 +405,9 @@ def test_process_auto(self):
assert_that(result, equal_to(['foo', 'bar']))
[email protected](sys.version_info[0] == 3,
Review comment:
This test hangs when executed on the master branch both in my local
environment as well as in an environment I set up on a VM. @RobbeSneyders
verified this and this is also the case in his environments.
The reason all IO changes pass the jenkins checks is because in tox.ini none
of the IO tests are being added and are therefore not checked. They are of
course presumably being tested locally, so it rarely results in an issue, but
if the local check is done before a rebase this could conflict with another
change imo, although in an indirect manner because otherwise there would be a
merge conflict. Do you think we should add the altered io tests to the tox file
from now on and go back to skipping remaining errors in order to pass the
jenkins environment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 167774)
Time Spent: 6h 40m (was: 6.5h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 6h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
